OCPBUGS-18354: owns watches config updates

[jakobmoellerdev]

This updates all cluster-scoped subresources to have 6 new labels useful for filtering and assignments (in place of the usual ownerreference) - csidriver, volumesnapshotclass,scc,storageclass will now receive these labels. These labels are also used to filter the watch to stop watching for unnecessary objects in the cluster.

On top of this, now LVMVolumeGroupNodeStatus receives OwnerReferences from LVMVolumeGroup. We can later decide to upgrade them to blockOwnerDeletion as well, but currently its a normal OwnerReference (no controller reference to avoid conflicts between multiple volume groups on one NodeStatus). If the volumegroup disappears from the node, so does the owner reference.

Snapshotting was moved to a similar check as SecurityContextConstraints to also allow a watch on the correct snapshot class. Sideeffect: if LVMS is installed after snapshot apis, a manual restart is necessary. For all openshift distros and people aware of this, this shouldnt be an issue since the APIs are usually installed before extension operators.

Also adds an Owns configuration to the LVMCluster for the deployment controller of topo lvm in addition to the already watched daemon set.

Now all resources except for the initially created CSIDriver are watched and reacted to on status.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18354, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This updates all cluster-scoped subresources to have 6 new labels useful for filtering and assignments (in place of the usual ownerreference) - csidriver, volumesnapshotclass,scc,storageclass will now receive these labels. These labels are also used to filter the watch to stop watching for unnecessary objects in the cluster.

On top of this, now LVMVolumeGroupNodeStatus receives OwnerReferences from LVMVolumeGroup. We can later decide to upgrade them to blockOwnerDeletion as well, but currently its a normal OwnerReference (no controller reference to avoid conflicts between multiple volume groups on one NodeStatus). If the volumegroup disappears from the node, so does the owner reference.

Snapshotting was moved to a similar check as SecurityContextConstraints to also allow a watch on the correct snapshot class. Sideeffect: if LVMS is installed after snapshot apis, a manual restart is necessary. For all openshift distros and people aware of this, this shouldnt be an issue since the APIs are usually installed before extension operators.

Also adds an Owns configuration to the LVMCluster for the deployment controller of topo lvm in addition to the already watched daemon set.

Now all resources except for the initially created CSIDriver are watched and reacted to on status.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jakobmoellerdev]

/test all

[codecov-commenter]

Codecov Report

Merging #405 (e1ef3e4) into main (dd8b3b7) will increase coverage by 0.04%.
The diff coverage is 45.04%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   57.07%   57.11%   +0.04%     
==========================================
  Files          27       27              
  Lines        2169     2227      +58     
==========================================
+ Hits         1238     1272      +34     
- Misses        846      868      +22     
- Partials       85       87       +2     

Files Changed	Coverage Δ
controllers/scc.go	0.00% <0.00%> (ø)
pkg/vgmanager/status.go	0.00% <0.00%> (ø)
pkg/vgmanager/vgmanager_controller.go	11.72% <0.00%> (-0.05%)	⬇️
controllers/lvmcluster_controller_watches.go	64.93% <58.49%> (-12.21%)	⬇️
controllers/lvmcluster_controller.go	63.58% <100.00%> (+0.60%)	⬆️
controllers/topolvm_csi_driver.go	80.00% <100.00%> (+0.51%)	⬆️
controllers/topolvm_snapshotclass.go	84.61% <100.00%> (+13.18%)	⬆️
controllers/topolvm_storageclass.go	85.29% <100.00%> (+0.67%)	⬆️
controllers/vgmanager.go	79.06% <100.00%> (+0.49%)	⬆️

[jeff-roche]

/lgtm

[jeff-roche]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeff-roche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[suleymanakbas91]

/lgtm

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-18354: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#405

Jira Issue OCPBUGS-18354 has been moved to the MODIFIED state.

In response to this:

This updates all cluster-scoped subresources to have 6 new labels useful for filtering and assignments (in place of the usual ownerreference) - csidriver, volumesnapshotclass,scc,storageclass will now receive these labels. These labels are also used to filter the watch to stop watching for unnecessary objects in the cluster.

On top of this, now LVMVolumeGroupNodeStatus receives OwnerReferences from LVMVolumeGroup. We can later decide to upgrade them to blockOwnerDeletion as well, but currently its a normal OwnerReference (no controller reference to avoid conflicts between multiple volume groups on one NodeStatus). If the volumegroup disappears from the node, so does the owner reference.

Snapshotting was moved to a similar check as SecurityContextConstraints to also allow a watch on the correct snapshot class. Sideeffect: if LVMS is installed after snapshot apis, a manual restart is necessary. For all openshift distros and people aware of this, this shouldnt be an issue since the APIs are usually installed before extension operators.

Also adds an Owns configuration to the LVMCluster for the deployment controller of topo lvm in addition to the already watched daemon set.

Now all resources except for the initially created CSIDriver are watched and reacted to on status.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.