OCPVE-677: chore: separate filter and lvm package from vgmanager

[jakobmoellerdev]

Part of the findings of vgmanager testing. This separates vgmanager into 3 packages:

1. lvm, now contains ALL calls to LVM in the codebase
2. filter, now contains our filter methods and gets included from vgmanager
3. vgmanager, now only calls to lvm and filter in the correct places

Also the previously raw command executor calls for thinpool creation/extension were moved into separate methods in lvm package so that the perogative to contain all lvm calls still remains.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of the findings of vgmanager testing. This separates vgmanager into 3 packages:

1. lvm, now contains ALL calls to LVM in the codebase
2. filter, now contains our filter methods and gets included from vgmanager
3. vgmanager, now only calls to lvm and filter in the correct places

Also the previously raw command executor calls for thinpool creation/extension were moved into separate methods in lvm package so that the perogative to contain all lvm calls still remains.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[suleymanakbas91]

I loved this!
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[codecov-commenter]

Codecov Report

Merging #410 (e0a0dd1) into main (8da92ee) will decrease coverage by 1.54%.
Report is 6 commits behind head on main.
The diff coverage is 10.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   55.01%   53.48%   -1.54%     
==========================================
  Files          27       27              
  Lines        2341     2468     +127     
==========================================
+ Hits         1288     1320      +32     
- Misses        965     1062      +97     
+ Partials       88       86       -2     

Files Changed	Coverage Δ
pkg/filter/filter.go	61.22% <0.00%> (ø)
pkg/lvm/lvm.go	38.25% <0.00%> (ø)
pkg/vgmanager/status.go	0.00% <0.00%> (ø)
pkg/vgmanager/vgmanager_controller.go	11.41% <5.00%> (+1.91%)	⬆️
pkg/vgmanager/devices.go	75.78% <33.33%> (-0.60%)	⬇️

... and 1 file with indirect coverage changes

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.