OCPVE-220: remove unused certificates

[suleymanakbas91]

This PR removes the initcontainer self-signed-cert-generator from TopoLVM Controller. This is because the certs are used for TopoLVM webhooks which are not deployed in LVMS.

Also, this PR removes the unused webhook and certmanager files to simplify the codebase.

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-220 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-220 which is a valid jira issue.

In response to this:

This PR removes the initcontainer self-signed-cert-generator from TopoLVM Controller. This is because the certs are used for TopoLVM webhooks which are not deployed in LVMS. As there is no option to disable this from TopoLVM, we just pass the existing webhook certs from LVMS to make the controller start, but the certs are not used afterwards.

Also, this PR removes the unused webhook and certmanager files to simplify the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-220 which is a valid jira issue.

In response to this:

This PR removes the initcontainer self-signed-cert-generator from TopoLVM Controller. This is because the certs are used for TopoLVM webhooks which are not deployed in LVMS. As there is no option to disable this from TopoLVM, we just pass the existing webhook certs from LVMS to make the controller start, but the certs are not used afterward.

Also, this PR removes the unused webhook and certmanager files to simplify the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

Less certs = more good!

Had a question regarding the necessary mount though since Im pretty sure this can be fixed in upstream. They already have flags in their helm chart for disabling it but maybe we also should contribute a code path that allows also omitting the mount. WDYT?

[suleymanakbas91]

/hold

[suleymanakbas91]

/test all

[suleymanakbas91]

/unhold

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR removes the initcontainer self-signed-cert-generator from TopoLVM Controller. This is because the certs are used for TopoLVM webhooks which are not deployed in LVMS.

Also, this PR removes the unused webhook and certmanager files to simplify the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[suleymanakbas91]

/retest

[suleymanakbas91]

/retest

[suleymanakbas91]

/retest

[codecov-commenter]

Codecov Report

Merging #413 (8c621ab) into main (9677ed3) will decrease coverage by 0.38%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   63.68%   63.31%   -0.38%     
==========================================
  Files          28       28              
  Lines        2360     2336      -24     
==========================================
- Hits         1503     1479      -24     
  Misses        709      709              
  Partials      148      148              

Files Changed	Coverage Δ
controllers/topolvm_controller.go	97.20% <100.00%> (-0.29%)	⬇️
controllers/vgmanager_daemonset.go	100.00% <100.00%> (ø)

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jakobmoellerdev]

/lgtm