Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28727: fix: allow stderr reporting via error and stdout reporting via logs when no parsing is run #567

Conversation

jakobmoellerdev
Copy link
Contributor

No description provided.

@jakobmoellerdev
Copy link
Contributor Author

/test all

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 31, 2024
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-28727, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 31, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@openshift-ci openshift-ci bot requested a review from radeore January 31, 2024 12:25
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (39f73d4) 82.47% compared to head (8075bba) 77.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   82.47%   77.53%   -4.94%     
==========================================
  Files          25       27       +2     
  Lines        1894     1945      +51     
==========================================
- Hits         1562     1508      -54     
- Misses        217      321     +104     
- Partials      115      116       +1     
Files Coverage Δ
...l/controllers/lvmcluster/logpassthrough/options.go 100.00% <100.00%> (ø)
internal/controllers/vgmanager/lvm/lvm.go 99.03% <100.00%> (-0.15%) ⬇️
internal/controllers/vgmanager/wipefs/wipefs.go 85.71% <100.00%> (-1.79%) ⬇️
internal/migration/tagging/tagging.go 83.01% <100.00%> (ø)
internal/controllers/vgmanager/wipe_devices.go 72.88% <50.00%> (ø)
internal/controllers/vgmanager/controller.go 73.60% <90.47%> (+0.20%) ⬆️
internal/controllers/vgmanager/devices.go 80.00% <0.00%> (ø)
internal/controllers/vgmanager/dmsetup/dmsetup.go 68.18% <50.00%> (-6.82%) ⬇️
internal/controllers/vgmanager/lsblk/lsblk.go 0.00% <0.00%> (ø)
internal/controllers/vgmanager/exec/exec.go 0.00% <0.00%> (ø)

Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@suleymanakbas91
Copy link
Contributor

/retest

@suleymanakbas91
Copy link
Contributor

/test precommit-check

@jakobmoellerdev jakobmoellerdev force-pushed the OCPBUGS-28727-stream-stderr-logging branch from 31eac5a to 7fe4b67 Compare February 1, 2024 11:16
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev force-pushed the OCPBUGS-28727-stream-stderr-logging branch from 7fe4b67 to ee13562 Compare February 1, 2024 11:57
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review February 1, 2024 13:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2024
@suleymanakbas91
Copy link
Contributor

/lgtm
/hold for TopoLVM PR review

Great work! Feel free to unhold it once the TopoLVM review is done :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the OCPBUGS-28727-stream-stderr-logging branch from ee13562 to 894a167 Compare February 6, 2024 10:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the OCPBUGS-28727-stream-stderr-logging branch from 894a167 to 8075bba Compare February 6, 2024 10:26
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm
/unhold

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f4c0b7b into openshift:main Feb 7, 2024
9 checks passed
@openshift-ci-robot
Copy link

@jakobmoellerdev: Jira Issue OCPBUGS-28727: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28727 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants