-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-922: Bring more visibility to dynamic device discovery by warnings and a new status field #615
OCPEDGE-922: Bring more visibility to dynamic device discovery by warnings and a new status field #615
Conversation
@suleymanakbas91: This pull request references OCPEDGE-922 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a6a6c1a
to
c85c847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition and not as crazy as my previous attempt. Overall lgtm, just a few minor things for docs and a small nit on the warning generation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 77.66% 77.75% +0.09%
==========================================
Files 27 27
Lines 1952 1960 +8
==========================================
+ Hits 1516 1524 +8
Misses 319 319
Partials 117 117
|
5fde32c
to
2e057bf
Compare
@suleymanakbas91: This pull request references OCPEDGE-922 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…nd a new status field Signed-off-by: Suleyman Akbas <[email protected]>
2e057bf
to
515675c
Compare
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds some admission warnings and more visibility through a status field in
LVMCluster
CRD in case the dynamic device discovery is enabled by not setting aDeviceSelector
.The new status field is called
DeviceDiscoveryPolicy
:DeviceDiscoveryPolicyPreconfigured
, the devices are preconfigured through aDeviceSelector
.DeviceDiscoveryPolicyRuntimeDynamic
, the devices are added to the VG if they are present at runtime.