Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-1005: must-gather: add support for --since and --since-time flags #616

Merged

Conversation

suleymanakbas91
Copy link
Contributor

oc adm must-gather has new flags --since and --since-time, which set MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME environment vars to limit log collection based on a specified time. This PR adds support for these flags to LVMS must-gather.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2024

@suleymanakbas91: This pull request references OCPEDGE-1005 which is a valid jira issue.

In response to this:

oc adm must-gather has new flags --since and --since-time, which set MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME environment vars to limit log collection based on a specified time. This PR adds support for these flags to LVMS must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (d36d392) to head (619ec5f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   77.65%   77.75%   +0.10%     
==========================================
  Files          27       27              
  Lines        1960     1960              
==========================================
+ Hits         1522     1524       +2     
+ Misses        320      319       -1     
+ Partials      118      117       -1     

see 1 file with indirect coverage changes

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a2f97fd into openshift:main Apr 25, 2024
9 checks passed
@suleymanakbas91 suleymanakbas91 deleted the must-gather-since branch April 25, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants