Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCOS] Update vendor and fix small go mod issue #1370

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

sgreene570
Copy link
Contributor

@sgreene570 sgreene570 commented Jan 14, 2020

Updated the vendor folder for the FCOS branch and ran into a snag with go mod vendor and permissions.

Fixed the update-codegen.sh script to explicitly call bash rather than ./ since the vendor'ed script won't have the execute bit set.

See golang/go#34965

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 14, 2020
@sgreene570
Copy link
Contributor Author

/assign @LorbusChris

@sgreene570
Copy link
Contributor Author

sgreene570 commented Jan 14, 2020

Should we look into some way of verifying that the vendor folder stays in sync with go.mod?

@openshift-ci-robot
Copy link
Contributor

@sgreene570: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws a5dbf40 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Member

@sgreene570 thank you! I'll rebase the fcps branch again for the Beta release and will include a new commit to update deps there anyway. Can you make this PR just include the first commit?

@LorbusChris
Copy link
Member

Actually, it doesn't matter, I'll cherry-pick later.
/override ci/prow/e2e-aws
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

@LorbusChris: LorbusChris unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

Actually, it doesn't matter, I'll cherry-pick later.
/override ci/prow/e2e-aws
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@LorbusChris
Copy link
Member

Oh well, I'm still not able to override due to a prob bug with upper case letters in GH username.

@vrutkovs
Copy link
Member

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants