-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FCOS] Update vendor and fix small go mod issue #1370
Conversation
/assign @LorbusChris |
Should we look into some way of verifying that the |
@sgreene570: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@sgreene570 thank you! I'll rebase the fcps branch again for the Beta release and will include a new commit to update deps there anyway. Can you make this PR just include the first commit? |
Actually, it doesn't matter, I'll cherry-pick later. |
@LorbusChris: LorbusChris unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh well, I'm still not able to override due to a prob bug with upper case letters in GH username. |
/override ci/prow/e2e-aws |
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updated the
vendor
folder for the FCOS branch and ran into a snag withgo mod vendor
and permissions.Fixed the
update-codegen.sh
script to explicitly call bash rather than./
since the vendor'ed script won't have the execute bit set.See golang/go#34965