daemon: Remove even more dead legacy OS update code #3820
Conversation
This code could have also been removed in openshift@85b297c "daemon: Remove old legacy OS update path" Beyond just removing dead code, a motivation is that calling `imageInspect()` which is trying to do out-of-band inspection of the booted image, which creates problems with fully-disconnected environments: https://issues.redhat.com/browse/RFE-4482
openshift-ci
bot
added
the
approved
|
This one I'm 97.3% certain is correct and has a very low chance of regressing anything. (I mean, just look - there's nothing that calls these functions! The code is just unused) |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This code could have also been removed in
85b297c "daemon: Remove old legacy OS update path"
Beyond just removing dead code, a motivation is that calling
imageInspect()which is trying to do out-of-band inspection of the booted image, which creates problems with fully-disconnected environments: https://issues.redhat.com/browse/RFE-4482