-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert " add Passwd to bootstrap served ignition" #3828
Revert " add Passwd to bootstrap served ignition" #3828
Conversation
@stbenjam: This pull request references Jira Issue OCPBUGS-16227, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance |
@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dbd6fba0-2d7f-11ee-909e-43c555f2ca09-0 |
@stbenjam: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/override ci/prow/e2e-aws-ovn-upgrade |
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepsm007, stbenjam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label approved |
/override ci/prow/e2e-gcp-op |
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-op In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Reverts #3811, tracked by TRT-1168
Per OpenShift policy, we are reverting this breaking change to get nightly payloads flowing again.
Workers are failing to provision on the nightly hypershift job (see jira above for details). The first payload hypershift broke contains this PR https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.nightly/release/4.14.0-0.nightly-2023-07-27-223709. After testing this revert, hypershift is installing again so this broke something related to ignition and hypershift.
See our test of this revert here, which made it past install: https://pr-payload-tests.ci.openshift.org/runs/ci/dbd6fba0-2d7f-11ee-909e-43c555f2ca09-0
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run
/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance
on the unrevert to confirm hypershift installs.cc: @cdoern, @sinnykumari