Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert " add Passwd to bootstrap served ignition" #3828

Merged

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Jul 28, 2023

Reverts #3811, tracked by TRT-1168

Per OpenShift policy, we are reverting this breaking change to get nightly payloads flowing again.

Workers are failing to provision on the nightly hypershift job (see jira above for details). The first payload hypershift broke contains this PR https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.nightly/release/4.14.0-0.nightly-2023-07-27-223709. After testing this revert, hypershift is installing again so this broke something related to ignition and hypershift.

See our test of this revert here, which made it past install: https://pr-payload-tests.ci.openshift.org/runs/ci/dbd6fba0-2d7f-11ee-909e-43c555f2ca09-0

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run /payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance on the unrevert to confirm hypershift installs.

cc: @cdoern, @sinnykumari

@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Jul 28, 2023
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 28, 2023
@openshift-ci-robot
Copy link
Contributor

@stbenjam: This pull request references Jira Issue OCPBUGS-16227, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #3811, tracked by TRT-1168

TRT suspects this PR as being a possible cause of a recent payload regression. We are floating this revert to perform additional testing. It seems unlikely this is the cause, but we don't have any other candidates at the moment. Workers are failing to provision on the nightly hypershift job (se jira above for details)

Holding pending confirmation:
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dbd6fba0-2d7f-11ee-909e-43c555f2ca09-0

@stbenjam stbenjam changed the title Revert "OCPBUGS-16227: add Passwd to bootstrap served ignition" Revert " add Passwd to bootstrap served ignition" Jul 28, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 28, 2023
@openshift-ci-robot
Copy link
Contributor

@stbenjam: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Reverts #3811, tracked by TRT-1168

TRT suspects this PR as being a possible cause of a recent payload regression. We are floating this revert to perform additional testing. It seems unlikely this is the cause, but we don't have any other candidates at the moment. Workers are failing to provision on the nightly hypershift job (se jira above for details)

Holding pending confirmation:
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 28, 2023
@stbenjam
Copy link
Member Author

/hold cancel
/skip
/label approved

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 28, 2023
@stbenjam
Copy link
Member Author

/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op

In response to this:

/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepsm007
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepsm007, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@stbenjam
Copy link
Member Author

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@stbenjam
Copy link
Member Author

/override ci/prow/e2e-gcp-op
/label approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-op

In response to this:

/override ci/prow/e2e-gcp-op
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2023

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants