Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-38869: MCN are not updated when we use OCL #4579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-38869: MCN are not updated when we use OCL #4579

wants to merge 1 commit into from

Conversation

dkhater-redhat
Copy link
Contributor

- What I did
Fixed a bug in updateOnClusterBuild where mcn's were not correctly updating their .spec.configVersion.desired field when using ocl. The fix involved leveraging the GenerateAndApplyMachineConfigNodeSpec function to ensure that the MCNs are correctly updated with the latest desired configuration after applying a new MachineConfig.

- How to verify it

  1. Enable ocl
  2. Apply a new mc that adds or modifies a file on the worker nodes.
  3. Verify that the .spec.configVersion.desired field of mcn's reflects the updated mc across all nodes in the worker pool.

- Description for the changelog
Fixed an issue where mcn's were not updating their .spec.configVersion.desired field correctly when using ocl in the mcd

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 10, 2024
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
Fixed a bug in updateOnClusterBuild where mcn's were not correctly updating their .spec.configVersion.desired field when using ocl. The fix involved leveraging the GenerateAndApplyMachineConfigNodeSpec function to ensure that the MCNs are correctly updated with the latest desired configuration after applying a new MachineConfig.

- How to verify it

  1. Enable ocl
  2. Apply a new mc that adds or modifies a file on the worker nodes.
  3. Verify that the .spec.configVersion.desired field of mcn's reflects the updated mc across all nodes in the worker pool.

- Description for the changelog
Fixed an issue where mcn's were not updating their .spec.configVersion.desired field correctly when using ocl in the mcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@dkhater-redhat
Copy link
Contributor Author

/test e2e-gcp-op-single-node

2 similar comments
@dkhater-redhat
Copy link
Contributor Author

/test e2e-gcp-op-single-node

@dkhater-redhat
Copy link
Contributor Author

/test e2e-gcp-op-single-node

umohnani8
umohnani8 reviewed Sep 16, 2024
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
@umohnani8
Copy link
Contributor

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024 •
edited
Loading

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview d08769f link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-upi-zones d08769f link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-zones d08769f link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-upi d08769f link false /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@umohnani8
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sergiordlr
Copy link

@dkhater-redhat Hello! We have problems installing the images created for the PRs (all the PRs not only this one). Nevertheless, nightly builds are installing without problems. Could you please merge this PR? we will test it post-merge in the nightly build. Thanks!!

We don't add the qe-approved label since it will verified post-merge.

@dkhater-redhat
Copy link
Contributor Author

/retest-required

@dkhater-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dkhater-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:

  • expected the bug to target only the "4.18.0" version, but multiple target versions were set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dkhater-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-38869, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umohnani8 umohnani8 umohnani8 left review comments

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkhater-redhat @openshift-ci-robot @umohnani8 @sergiordlr