Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20151: [CHERRY PICK FROM UPSTREAM]: Take optional attributes into account for fibre_channel metrics #144

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

machine424
Copy link

@machine424 machine424 commented Apr 24, 2024

update github.com/prometheus/procfs to v0.13.0 for fibre_channel to
take into account optional attributes

Updates procfs to get: prometheus/procfs#607, other notable changes in v0.13.0: https://github.com/prometheus/procfs/releases/tag/v0.13.0
Cherry-picked prometheus#2933 from node-exporter to get the tests

A new version of upstream node exporter with github.com/prometheus/procfs to v0.13.0 isn't available yet.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link

@machine424: This pull request references Jira Issue OCPBUGS-20151, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

update github.com/prometheus/procfs to v0.13.0 for fibre_channel to
take into account optional attributes

Updates procfs to get: prometheus/procfs#607
Cherry-picked prometheus#2933 from node-exporter to get the tests

A new version of upstream node exporter with github.com/prometheus/procfs to v0.13.0 isn't available yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@machine424
Copy link
Author

/retest

@jan--f
Copy link

jan--f commented Apr 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 24, 2024

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@machine424
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link

@machine424: This pull request references Jira Issue OCPBUGS-20151, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Tai-RedHat April 24, 2024 16:29
@openshift-merge-bot openshift-merge-bot bot merged commit 6abe034 into openshift:master Apr 24, 2024
7 checks passed
@openshift-ci-robot
Copy link

@machine424: Jira Issue OCPBUGS-20151: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20151 has been moved to the MODIFIED state.

In response to this:

update github.com/prometheus/procfs to v0.13.0 for fibre_channel to
take into account optional attributes

Updates procfs to get: prometheus/procfs#607, other notable changes in v0.13.0: https://github.com/prometheus/procfs/releases/tag/v0.13.0
Cherry-picked prometheus#2933 from node-exporter to get the tests

A new version of upstream node exporter with github.com/prometheus/procfs to v0.13.0 isn't available yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build golang-github-prometheus-node_exporter-container-v4.16.0-202404241818.p0.g6abe034.assembly.stream.el9 for distgit golang-github-prometheus-node_exporter.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants