fix: Velero server args organization #1535
Conversation
Signed-off-by: Mateus Oliveira <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
cc @kaovilai |
|
@mateusoliveira43: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // does not let us avoid the =true, and that shorthand is necessary for | ||
| // compatibility. TODO: does this matter enough to fix? Seems unlikely. | ||
| // +optional | ||
| ToStderr *bool `json:"logtostderr,omitempty"` // The -logtostderr flag. |
There was a problem hiding this comment.
We are losing context where things came from.
Like that this came from https://github.com/openshift/velero/blob/240b4e666fe15ef98defa2b51483fe87ac9996fb/pkg/cmd/velero/velero.go#L125
Prior code had these in comments. I would add these comments back in.
Unless this refactor is meant to be short lived, I am in favor of having a map of where things came from.
Why the changes were made
I think it is easier to read the code if all YAML definitions logic are in
api/v1alpha1folder.How to test the changes made
Check that output of
make bundlewas not changed by these changes.