Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHEL upgrade: use API to get ignition from machine config #11614

Merged
merged 1 commit into from
May 16, 2019
Merged

RHEL upgrade: use API to get ignition from machine config #11614

merged 1 commit into from
May 16, 2019

Conversation

mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented May 15, 2019 •
edited
Loading

Switch from using bootstrap ignition config from MCS to using the
ignition config from the worker machine config obtained from the
cluster API.

Bug 1710226
https://bugzilla.redhat.com/show_bug.cgi?id=1710226

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2019
@mtnbikenc
Copy link
Member Author

mtnbikenc commented May 15, 2019 •
edited
Loading

The apply_machine_config.yml task file repeats much of the install.yml task file. If this approach works, I plan to refactor this to have one set of apply tasks that work for both install and upgrade.

@mtnbikenc mtnbikenc force-pushed the fix-1710226 branch 2 times, most recently from d2a9ec7 to eb41d2d Compare May 15, 2019 18:38
@mtnbikenc
Copy link
Member Author

mcd is failing:

"stdout_lines": [
        "I0515 18:27:46.342901       1 start.go:67] Version: 4.1.0-201905091432-dirty",
        "I0515 18:27:46.343553       1 start.go:100] Starting node writer",
        "I0515 18:27:46.343581       1 start.go:107] Cannot initialize ClientBuilder, likely in onceFrom mode with Ignition",
        "I0515 18:27:46.343630       1 start.go:196] Calling chroot(\"/rootfs\")",
        "I0515 18:27:46.343643       1 start.go:206] Starting MachineConfigDaemon",
        "I0515 18:27:46.343790       1 update.go:743] Starting to manage node: ip-10-0-135-71",
        "I0515 18:27:46.347750       1 run.go:22] Running captured: journalctl --list-boots",
        "I0515 18:27:46.350539       1 daemon.go:743] journalctl --list-boots:",
        " 0 5d8d91bb723542a7b59110a2095ac6d8 Wed 2019-05-15 15:36:32 UTC—Wed 2019-05-15 18:27:46 UTC",
        "I0515 18:27:46.350574       1 daemon.go:491] Enabling Kubelet Healthz Monitor",
        "I0515 18:27:46.357177       1 asm_amd64.s:573] Shutting down MachineConfigDaemon",
        "panic: runtime error: invalid memory address or nil pointer dereference",
        "[signal SIGSEGV: segmentation violation code=0x1 addr=0xb8 pc=0x10a4086]",

@vrutkovs
Copy link
Member

Cluster failed to start
/retest

@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member 

Failure talking to yum: failure: repodata/repomd.xml from origin-pr: [Errno 256] No more mirrors to try.
    https://rpms.svc.ci.openshift.org/openshift-origin-v4.2/repodata/repomd.xml: [Errno 14] HTTPS Error 404 - Not Found

Not sure if this is transient, lets try again

/retest

@knobunc
Copy link
Contributor

knobunc commented May 16, 2019

/retest

@runcom
Copy link
Member

runcom commented May 16, 2019

/hold

@mtnbikenc is testing #11614 (comment)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2019
@mtnbikenc
RHEL upgrade: use API to get ignition from machine config
e9a349d 
Switch from using bootstrap ignition config from MCS to using the
ignition config from the worker machine config obtained from the
cluster API.
@mtnbikenc mtnbikenc changed the title [WIP] Change RHEL upgrade to use machine config from API [WIP] RHEL upgrade: use API to get ignition from machine config May 16, 2019
@runcom
Copy link
Member

runcom commented May 16, 2019

can we lift the WIP here? looks like this is good in the upgrade scenario and would only love some DR testing now

@mtnbikenc mtnbikenc changed the title [WIP] RHEL upgrade: use API to get ignition from machine config RHEL upgrade: use API to get ignition from machine config May 16, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2019
@mtnbikenc
Copy link
Member Author

Updated to pull ignition config from machine config and tested on dev cluster.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2019
@mtnbikenc mtnbikenc mentioned this pull request May 16, 2019
Merged
@knobunc
Copy link
Contributor

knobunc commented May 16, 2019

/retest

@runcom
Copy link
Member

runcom commented May 16, 2019

@vrutkovs @mtnbikenc are scaleup jobs passing in master/4.2?

@mtnbikenc
Copy link
Member Author

@vrutkovs @mtnbikenc are scaleup jobs passing in master/4.2?

The 4.2 repo didn't exist. That was fixed but it has 4.1 rpms. Repo fixes still in progress. That's why I manually backported to release-4.1.

@mtnbikenc
Copy link
Member Author

This passed scaleup phase so repos are working now.

@mtnbikenc
Copy link
Member Author

/refresh

@mtnbikenc
Copy link
Member Author

/retest

@mtnbikenc
Copy link
Member Author

/retest

Failing tests:

[sig-instrumentation] MetricsGrabber should grab all metrics from a Kubelet. [Suite:openshift/conformance/parallel] [Suite:k8s]

@knobunc
Copy link
Contributor

knobunc commented May 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2019
@crawford
Copy link

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, knobunc, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fb59e73 into openshift:master May 16, 2019
@mtnbikenc mtnbikenc deleted the fix-1710226 branch May 17, 2019 12:36
@cgwalters cgwalters mentioned this pull request Nov 25, 2019
Closed
@cgwalters cgwalters mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs left review comments

@runcom runcom runcom left review comments

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mtnbikenc @vrutkovs @knobunc @runcom @crawford @openshift-ci-robot @openshift-merge-robot