-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete properties from console config map #6754
Remove obsolete properties from console config map #6754
Conversation
Corresponding origin PR: openshift/origin#18191 |
e08dfc9
to
9d96719
Compare
Stop writing deprecated config to the console config map.
9d96719
to
b74651d
Compare
@sdodson This is almost ready, although we might want to wait for an enterprise image that contains openshift/origin-web-console-server#20 cc @jupierce |
Tests are failing because a new origin-web-console image hasn't been pushed since openshift/origin-web-console-server#20 merged. |
New origin-web-console image pushed /retest |
/lgtm As discussed, the OSE image and ansible packages are built at the same time so if the image changes have merged already then this should be safe to land now. |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test install |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test install |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test install |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test logging |
/test install |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
@spadgett: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…nfig Automatic merge from submit-queue. Remove obsolete properties from console config map Stop writing deprecated config to the console config map. /hold This can't be merged until openshift/origin-web-console-server#20 merges. Follow on to openshift#6730
Stop writing deprecated config to the console config map.
/hold
This can't be merged until openshift/origin-web-console-server#20 merges.
Follow on to #6730