Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete properties from console config map #6754

Merged

Conversation

spadgett
Copy link
Member

Stop writing deprecated config to the console config map.

/hold

This can't be merged until openshift/origin-web-console-server#20 merges.
Follow on to #6730

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2018
@spadgett
Copy link
Member Author

Corresponding origin PR: openshift/origin#18191

Stop writing deprecated config to the console config map.
@spadgett
Copy link
Member Author

spadgett commented Jan 19, 2018

@sdodson This is almost ready, although we might want to wait for an enterprise image that contains openshift/origin-web-console-server#20

cc @jupierce

@spadgett
Copy link
Member Author

Tests are failing because a new origin-web-console image hasn't been pushed since openshift/origin-web-console-server#20 merged.

@spadgett spadgett changed the title [DO NOT MERGE] Remove old console asset config Remove obsolete properties from console config map Jan 19, 2018
@spadgett
Copy link
Member Author

New origin-web-console image pushed

/retest

@sdodson
Copy link
Member

sdodson commented Jan 19, 2018

/lgtm
/hold cancel

As discussed, the OSE image and ansible packages are built at the same time so if the image changes have merged already then this should be safe to land now.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 19, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@spadgett
Copy link
Member Author

/test install

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@spadgett
Copy link
Member Author

/test install

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@spadgett
Copy link
Member Author

/test install

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@spadgett
Copy link
Member Author

/test logging

@spadgett
Copy link
Member Author

/test install

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit b1f728d into openshift:master Jan 21, 2018
@openshift-ci-robot
Copy link

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio b74651d link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mjudeikis pushed a commit to mjudeikis/openshift-ansible that referenced this pull request Jan 22, 2018
…nfig

Automatic merge from submit-queue.

Remove obsolete properties from console config map

Stop writing deprecated config to the console config map.

/hold

This can't be merged until openshift/origin-web-console-server#20 merges.
Follow on to openshift#6730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants