Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI changes as per the latest tkn release #21720

Merged
merged 1 commit into from
May 6, 2020
Merged

CLI changes as per the latest tkn release #21720

merged 1 commit into from
May 6, 2020

Conversation

nkakkar81
Copy link
Contributor

@nkakkar81 nkakkar81 commented Apr 30, 2020 •
edited
Loading

This PR contains changes as per the 0.9.0 tkn release

The PR is reviewed and approved by SME and QE.

Issues included:
tektoncd/cli#594 - All commands added
tektoncd/cli#944
tektoncd/cli#943

@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@piyush-garg
Copy link

LGTM

@nkakkar81 nkakkar81 changed the title CLI changes as per the latest tkn release [WIP] CLI changes as per the latest tkn release Apr 30, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2020
@pradeepitm12
Copy link

lgtm

ppitonak
ppitonak approved these changes May 4, 2020
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@nkakkar81 nkakkar81 changed the title [WIP] CLI changes as per the latest tkn release CLI changes as per the latest tkn release May 5, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@bergerhoffer bergerhoffer added branch/enterprise-4.4 branch/enterprise-4.5 peer-review-needed Signifies that the peer review team needs to review this PR labels May 5, 2020
@bergerhoffer bergerhoffer added this to the Next Release milestone May 5, 2020
bergerhoffer
bergerhoffer reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things!

cli_reference/tkn_cli/installing-tkn.adoc Outdated Show resolved Hide resolved
modules/op-tkn-condition-management.adoc
== condition describe
Describe a Condition.

.Example: Describe the `mycondition1` Condition in a namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is consistent with how you use it throughout this doc, but I'd consider saying "in the myspace namespace", throughout the examples in the doc. Since you specifically call out myCondition1 and say "in a namespace" in the title but don't use angle brackets around to indicate that it's replaceable.

Copy link
Contributor Author

@nkakkar81 nkakkar81 May 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bergerhoffer - This was debated before as well, QE was of the opinion of removing the "in the myspace namespace" altogether from the example. As per them it sounded too long and repetitive, and did not add any value. We concluded to remove just "myspace"and retain only "in a namespace".

Let me know if thats ok with you :)

modules/op-tkn-trigger-management.adoc Show resolved Hide resolved
modules/op-tkn-trigger-management.adoc Outdated Show resolved Hide resolved
@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 5, 2020
@bergerhoffer
Copy link
Contributor

LGTM now, just need to squash!

@bergerhoffer bergerhoffer merged commit d49ebcd into openshift:master May 6, 2020
@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.5

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #21852

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #21853

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@ppitonak ppitonak ppitonak approved these changes

Assignees

@ppitonak ppitonak

Labels
branch/enterprise-4.4 branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
8 participants
@nkakkar81 @openshift-docs-preview-bot @piyush-garg @pradeepitm12 @openshift-ci-robot @bergerhoffer @openshift-cherrypick-robot @ppitonak