Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKD Hide Web Terminal Assembly #46331

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

mburke5678
Copy link
Contributor

The Web Terminal Operator is not supported in OKD. This PR hides the About the web terminal in the web console assembly.

okd-project/okd#456 (comment)

Previews;
OKD - Assembly is not present
OCP - Assembly is present

@mburke5678 mburke5678 added this to the Next Release milestone Jun 3, 2022
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2022
@openshift openshift deleted a comment from vladikr Jun 3, 2022
@mburke5678
Copy link
Contributor Author

@vrutkovs PTAL

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@mburke5678 mburke5678 merged commit 4f28202 into openshift:main Jun 6, 2022
@mburke5678 mburke5678 deleted the okd-remove-web-terminal branch June 6, 2022 13:02
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46349

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.7

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.8

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.9

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.10

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46350

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46351

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46352

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46353

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #46354

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. okd-only Content that is only relevant to upstream OKD docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants