Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oc create secret instead of deprecated oc secrets subcommands #7262

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

soltysh
Copy link

@soltysh soltysh commented Jan 22, 2018

openshift/origin#18093 deprecated several oc secrets sub commands. This PR changes our docs not to use them, but instead use the supported versions.

@openshift/team-documentation this will require also release notes, something along the lines:

OpenShfit 3.9 deprecates following oc secrets sub commands:   new, new-basicauth, new-dockercfg, new-sshauth in favor of oc create secret. 

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2018
@vikram-redhat
Copy link
Contributor

Thanks @soltysh - I am assuming for 3.9 onwards, right?

@soltysh
Copy link
Author

soltysh commented Jan 24, 2018

@vikram-redhat that's correct

@ahardin-rh
Copy link
Contributor

ahardin-rh commented Jan 24, 2018

These changes LGTM and I've noted this in our Release Note Tracker.
@stuartchuan Can you please QE these changes? Thanks!

@stuartchuan
Copy link

@ahardin-rh The changes LGTM, have verified.

@ahardin-rh
Copy link
Contributor

@soltysh @stuartchuan Thank you!

@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../dev_guide/builds/build_inputs.adoc#dev-guide-build-inputs[Builds -> Build Inputs]
|Removed deprecated oc secrets subcommands and replaced them with oc create secret commands.
%
|xref:../dev_guide/managing_images.adoc#dev-guide-managing-images[Managing Images]
|Removed deprecated oc secrets subcommands and replaced them with oc create secret commands.
%
|xref:../dev_guide/service_accounts.adoc#dev-guide-service-accounts[Service Accounts]
|Removed deprecated oc secrets subcommands and replaced them with oc create secret commands.
%

@ahardin-rh ahardin-rh merged commit 36a153b into openshift:master Jan 25, 2018
ahardin-rh pushed a commit to ahardin-rh/openshift-docs that referenced this pull request Jan 25, 2018
ahardin-rh pushed a commit to ahardin-rh/openshift-docs that referenced this pull request Jan 25, 2018
ahardin-rh pushed a commit to ahardin-rh/openshift-docs that referenced this pull request Jan 25, 2018
@soltysh soltysh deleted the deprecate_secrets branch January 29, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/dedicated branch/enterprise-3.9 branch/online size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants