Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for SRVKS-1174: Document how users can utilize full duplex support for http1 #76331

Merged
merged 1 commit into from
Jun 4, 2024
Merged

PR for SRVKS-1174: Document how users can utilize full duplex support for http1 #76331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions _topic_maps/_topic_map.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,8 @@ Topics:
File: customize-labels-annotations-routes
- Name: Configuring routes for Knative services
File: configuring-service-routes
- Name: Global HTTPS redirection
File: https-redirect-global
- Name: URL scheme for external routes
File: url-scheme-external-routes
- Name: HTTPS redirection per service
File: https-redirect-per-service
- Name: Cluster local availability
File: cluster-local-availability
- Name: Kourier Gateway service type
Expand All @@ -174,6 +170,15 @@ Topics:
File: using-http2-gRPC
- Name: Using Serving with OpenShift ingress sharding
File: using-serving-with-ingress-sharding
- Name: HTTP configuration
Dir: http-configuration
Topics:
- Name: Global HTTPS redirection
File: https-redirect-global
- Name: HTTPS redirection per service
File: https-redirect-per-service
- Name: Full duplex support for HTTP/1
File: http1-full-duplex-support
Comment on lines +173 to +181
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a full subdirectory? Especially considering each of the 3 assemblies only have 1 module in each (with no TOCs).

Could this instead just be a single new "HTTP configuration" assembly that include::s the 3 modules (the 2 old ones and the 1 new one)? I feel like that would still satisfy the Jira ticket's request to "create another section".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does need to be a full subdirectory as each assemblies are going to expand by the upcoming next release and will contain the multiple modules. That is why I created like that. :)

- Name: Configuring access to Knative services
Dir: config-access
Topics:
Expand Down
1 change: 1 addition & 0 deletions knative-serving/http-configuration/_attributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../_attributes/
31 changes: 31 additions & 0 deletions knative-serving/http-configuration/http1-full-duplex-support.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
:_content-type: ASSEMBLY
include::_attributes/common-attributes.adoc[]
[id="http1-full-duplex-support"]
= Full duplex support for HTTP/1
:context: http1-full-duplex-support

You can enable the HTTP/1 full duplex support for a service by configuring the `features.knative.dev/http-full-duplex` annotation.

[NOTE]
====
Verify your HTTP clients before enabling, as earlier version clients might not provide support for HTTP/1 full duplex.
====

The following example shows how you can use this annotation in a Knative `Service` YAML object at the revision spec level:

.Example `KnativeServing` CR that provides full duplex support for HTTP/1
[source,yaml]
----
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: example-service
namespace: default
spec:
template:
spec:
annotations:
features.knative.dev/http-full-duplex: "Enabled"
...
----

0 ...ngress-routing/https-redirect-global.adoc → ...-configuration/https-redirect-global.adoc
View file
Open in desktop
File renamed without changes.
0 ...s-routing/https-redirect-per-service.adoc → ...iguration/https-redirect-per-service.adoc
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions knative-serving/http-configuration/images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../images/
1 change: 1 addition & 0 deletions knative-serving/http-configuration/modules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../modules/
1 change: 1 addition & 0 deletions knative-serving/http-configuration/snippets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../snippets/
2 changes: 1 addition & 1 deletion modules/serverless-https-redirect-global.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Module included in the following assemblies:
//
// * serverless/knative-serving/external-ingress-routing/https-redirect-global.adoc
// * serverless/knative-serving/http-configuration/https-redirect-global.adoc

:_content-type: REFERENCE
[id="serverless-https-redirect-global_{context}"]
Expand Down