Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds registry.access.redhat.com to firewall allowlist list #79926

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

stevsmit
Copy link
Member

@stevsmit stevsmit commented Aug 2, 2024

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-37868

Link to docs preview:
https://79926--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall.html

QE review:

  • QE has approved this change.

Additional information:

modules/configuring-firewall.adoc Outdated Show resolved Hide resolved
modules/configuring-firewall.adoc Outdated Show resolved Hide resolved
@stevsmit stevsmit force-pushed the 37868-OCPBUGS branch 2 times, most recently from 905a604 to 7bafbf2 Compare August 2, 2024 15:37
@patrickdillon
Copy link
Contributor

LGTM

@stevsmit stevsmit added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 5, 2024
@adellape adellape self-assigned this Aug 5, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 5, 2024
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 5, 2024
@gpei
Copy link

gpei commented Aug 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Copy link

openshift-ci bot commented Aug 7, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 7, 2024

@stevsmit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 82ef771 into openshift:main Aug 7, 2024
2 checks passed
@stevsmit
Copy link
Member Author

stevsmit commented Aug 7, 2024

/cherry-pick enterprise-4.17

@stevsmit
Copy link
Member Author

stevsmit commented Aug 7, 2024

/cherry-pick enterprise-4.16

@stevsmit
Copy link
Member Author

stevsmit commented Aug 7, 2024

/cherry-pick enterprise-4.15

@stevsmit
Copy link
Member Author

stevsmit commented Aug 7, 2024

/cherry-pick enterprise-4.14

@stevsmit
Copy link
Member Author

stevsmit commented Aug 7, 2024

/cherry-pick enterprise-4.13

@stevsmit
Copy link
Member Author

stevsmit commented Aug 7, 2024

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot

@stevsmit: new pull request created: #80151

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #80152

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #80153

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #80154

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: #79926 failed to apply on top of branch "enterprise-4.13":

Applying: Adds registry.access.redhat.com to firewall allowlist list
.git/rebase-apply/patch:19: trailing whitespace.
|`registry.access.redhat.com` 
.git/rebase-apply/patch:21: trailing whitespace.
|Hosts all the container images that are stored on the Red Hat Ecosystem Catalog, including core container images. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adds registry.access.redhat.com to firewall allowlist list
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: #79926 failed to apply on top of branch "enterprise-4.12":

Applying: Adds registry.access.redhat.com to firewall allowlist list
.git/rebase-apply/patch:19: trailing whitespace.
|`registry.access.redhat.com` 
.git/rebase-apply/patch:21: trailing whitespace.
|Hosts all the container images that are stored on the Red Hat Ecosystem Catalog, including core container images. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adds registry.access.redhat.com to firewall allowlist list
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants