Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On membership, in edit mode, on the edge between tablet & larger screens, there is a potential layout wobble #1219

Closed
benjaminapetersen opened this issue Feb 3, 2017 · 7 comments
Assignees
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@benjaminapetersen
Copy link
Contributor

With long or multiple roles, between ~765px and ~820px screen width there is the potential for this:
screen shot 2017-02-03 at 11 35 03 am

@benjaminapetersen benjaminapetersen self-assigned this Feb 3, 2017
@benjaminapetersen benjaminapetersen added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Feb 3, 2017
@spadgett
Copy link
Member

spadgett commented Feb 3, 2017

Honestly I wonder if Bootstrap grid or even a table isn't better than flex for layouts like this.

@benjaminapetersen
Copy link
Contributor Author

Agree, might be worth a restructure after all.

@benjaminapetersen
Copy link
Contributor Author

Ideas:

  • Could drop the 3rd column if we had a + action in the roles list that would open a dialog
  • Could also eliminate edit/non-edit mode with the above + actions
  • Or could list the role chips under the name, which would leave plenty of space (2 column again)

@sg00dwin sg00dwin self-assigned this Jun 22, 2017
@sg00dwin
Copy link
Member

sg00dwin commented Jun 27, 2017

There are various width/states, both edit and non-edit mode where content elements are breaking the layout.

Adding examples:
screen shot 2017-06-27 at 12 28 59 pm
screen shot 2017-06-27 at 12 28 11 pm

screen shot 2017-06-27 at 1 17 14 pm

screen shot 2017-06-27 at 12 31 03 pm

@sg00dwin
Copy link
Member

Posting some exploratory wireframes showing members and roles using PF list-view expand rows to address scalability and be consistent with other views.

View by member
membership by user01

View by member expanded
membership by user expanded01

Add member
membership add user s 01

View by Role
membership by role01

View by Role expanded
membership by role expanded01

cc @benjaminapetersen @jwforres @spadgett

@benjaminapetersen
Copy link
Contributor Author

A quick hack @ the first image above could look something like this (keeping the tabs we have):

screen shot 2017-07-18 at 4 24 12 pm

@beanh66
Copy link
Member

beanh66 commented Jul 19, 2017

@spadgett @benjaminapetersen I like what you have as a more immediate fix. Curious what it looks like when a row is expanded? In regards to the wireframes from @sg00dwin, I like the list view idea there too! As I mentioned we did something similar in the past with assigning roles to a list of names so here is a quick view of that functionality: http://g.recordit.co/GB9EJqbG9a.gif
In this case we used a table, but I could also see it in a list view instead. When there were too many roles to display on one row we just wrapped onto a second line so the rows got taller as needed. Not sure how we would incorporate the role descriptions but something to explore further.

sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 17, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 19, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 20, 2017
spadgett pushed a commit to spadgett/origin-web-console that referenced this issue Oct 23, 2017
openshift-merge-robot added a commit that referenced this issue Oct 23, 2017
Automatic merge from submit-queue.

Membership updates to correct broken layouts when multiple roles assigned

Overall code cleanup
Fixes #1219

@sg00dwin is the commit author.
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 23, 2017
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
4 participants