Navigate filters sometime throw errors when navigating to builds

[benjaminapetersen]

navigateResourceURL and navigateEventInvolvedObjectURL (and perhaps the others) occasionally cause an error to be thrown when navigating to builds:

error on line 105:

The breadcrumbs are not generated correctly due to the URL having a slightly different format.
Breadcrumb when error thrown:

Breadcrumb when error not thrown:

URL generating breadcrumbs with error:

https://localhost:9000/dev-console/project/myproject/browse/builds-noconfig/mmmmmm-cake-1?tab=details

URL generating correct breadcrumbs:

https://localhost:9000/dev-console/project/myproject/browse/builds/mmmmmm-cake/mmmmmm-cake-1?tab=details

So problem seems to be that the navigate* functions may think a build has no build config.

@spadgett

[benjaminapetersen]

This can be reproduced on the Monitoring page and in the Notification drawer.

Resolution per conversation is probably to look @ the Build Config annotation on the build rather than check the URL (via new ownerRefs).

[spadgett]

We might just remove the build config name from the URL like we did for replication controllers owned by a deployment config. Then you can build the URL from just the kind and name without needing other data. If we do that, we'd want a redirect for the old URL for old links.

We probably have a problem for pipeline builds vs regular builds as well since we use a pipeline URL segment for pipeline builds.

[benjaminapetersen]

Hmm. Yeah, this one does seem complex then, since we have so many routes using BuildController:

.when('/project/:project/browse/builds/:buildconfig/:build', {
  controller: 'BuildController',
  //
})
.when('/project/:project/browse/pipelines/:buildconfig/:build', {
  controller: 'BuildController',
  //
})
.when('/project/:project/browse/builds-noconfig/:build', {
  controller: 'BuildController',
  //
})
.when('/project/:project/browse/pipelines-noconfig/:build', {
  controller: 'BuildController',
  //
})

[jwforres]

The javascript error is being fixed in #2403
We will make the longer term URL change next release

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale