Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pod presets during binding to applications #1672

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

jwforres
Copy link
Member

@jwforres jwforres commented Jun 8, 2017

No description provided.

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminapetersen
Copy link
Contributor

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 4533cd5

@openshift-bot
Copy link

openshift-bot commented Jun 8, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1489/) (Base Commit: 9fd7f5b)

@jwforres
Copy link
Member Author

jwforres commented Jun 8, 2017

@rhamilto should be unblocked you and @benjaminapetersen will need to use the images pmorie/apiserver:pod-preset and pmorie/controller-manager:pod-preset for now for service catalog to test things out

also need to give svc cat service account cluster-admin instead of admin for the moment

oc adm policy add-cluster-role-to-user cluster-admin system:serviceaccount:service-catalog:default

@openshift-bot openshift-bot merged commit e18553f into openshift:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants