Bug 1460122 - Only use confirm-on-exit on some forms #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
rollback-confirm-on-exit
branch
from
aa7db6a
to
c3a2b78
Compare
spadgett
changed the title
|
This changes only the in-place environment variable editors and the edit YAML action to use confirm-on-exit. @jwforres PTAL |
Use confirm-on-exit only on forms where the left navigation is visible or where you might have typed a lot of content, such as Edit YAML.
spadgett
force-pushed
the
rollback-confirm-on-exit
branch
from
c3a2b78
to
0ae3bbf
Compare
spadgett
changed the title
jwforres
approved these changes
Jun 9, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 0ae3bbf |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1492/) (Base Commit: 513fa44) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use confirm-on-exit only on forms where the left navigation is visible or where you might have typed a lot of content, such as Edit YAML.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1460122