-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1461702 - Fix display of build webhooks to support new types #1720
Bug 1461702 - Fix display of build webhooks to support new types #1720
Conversation
The build-config.html diff looks big because i fixed an indention issue with that section of the template |
We had a lot of broken links :( |
[merge][severity: blocker] |
Also fixes outdated documentation links.
hmm, travis is fine with the dist but jenkins failed on main.css, it looks right to me though... lemme kick it again and see what happens [merge][severity: blocker] |
@spadgett concerned that this keeps getting a CSS dist in Jenkins, and only Jenkins... |
We might start printing the content of the diff instead of just the files so we know what's really different. |
aeab9b6
to
23877c8
Compare
added a commit to switch to use git diff |
Evaluated for origin web console test up to 23877c8 |
Evaluated for origin web console merge up to 23877c8 |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1555/) (Base Commit: 6afcb56) (PR Branch Commit: 23877c8) (Extended Tests: blocker) |
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1554/) (Base Commit: 6afcb56) (PR Branch Commit: 23877c8) |
Also fixes outdated documentation links.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1461702