Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1461702 - Fix display of build webhooks to support new types #1720

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

jwforres
Copy link
Member

Also fixes outdated documentation links.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1461702

@jwforres jwforres requested a review from spadgett June 15, 2017 17:23
@jwforres
Copy link
Member Author

The build-config.html diff looks big because i fixed an indention issue with that section of the template

@spadgett
Copy link
Member

We had a lot of broken links :(

@spadgett
Copy link
Member

[merge][severity: blocker]

@jwforres
Copy link
Member Author

hmm, travis is fine with the dist but jenkins failed on main.css, it looks right to me though...

lemme kick it again and see what happens

[merge][severity: blocker]

@jwforres
Copy link
Member Author

@spadgett concerned that this keeps getting a CSS dist in Jenkins, and only Jenkins...

@spadgett
Copy link
Member

We might start printing the content of the diff instead of just the files so we know what's really different.

@jwforres jwforres force-pushed the bug-1461702-webhook-details branch from aeab9b6 to 23877c8 Compare June 16, 2017 13:16
@jwforres
Copy link
Member Author

added a commit to switch to use git diff
[test]

@openshift-bot
Copy link

Evaluated for origin web console test up to 23877c8

@openshift-bot
Copy link

Evaluated for origin web console merge up to 23877c8

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1555/) (Base Commit: 6afcb56) (PR Branch Commit: 23877c8) (Extended Tests: blocker)

@openshift-bot
Copy link

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1554/) (Base Commit: 6afcb56) (PR Branch Commit: 23877c8)

@openshift-bot openshift-bot merged commit 370db11 into openshift:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants