-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show new builds in collapsed overview rows #1723
Conversation
app/scripts/services/builds.js
Outdated
var displayName = getBuildDisplayName(build, buildConfig.metadata.name); | ||
var runPolicy = _.get(buildConfig, 'spec.runPolicy'); | ||
if (runPolicy === 'Serial' || runPolicy === 'SerialLatestOnly') { | ||
details = "The build has been queued with run policy " + camelToLower(runPolicy) + "."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sentence seems like it reads strangely to me
maybe "This build has been queued under a serial run policy." and not worry about the distinction between serial and serial latest only? The important thing is that its not parallel.
alternatively "This build is configured to run serially and has been added to the queue."
81ca713
to
b28785b
Compare
updated |
app/scripts/services/builds.js
Outdated
if (runPolicy === 'Serial' || runPolicy === 'SerialLatestOnly') { | ||
message = _.capitalize(buildType) + " " + displayName + " successfully queued."; | ||
details = "Builds for " + buildConfig.metadata.name + " are configured to run one at a time."; | ||
// details = "This build has been configured to run serially and has been added to the queue."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this comment?
Only show Pending, Running, Failed, and Error in the collapsed row. Don't show new builds, but update the toast notification to say that the build is queued.
b28785b
to
7acebf8
Compare
Comment removed, thanks |
[merge][severity:bug] |
Evaluated for origin web console merge up to 7acebf8 |
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1550/) (Base Commit: c0d9ac2) (PR Branch Commit: 7acebf8) (Extended Tests: bug) |
Only show Pending, Running, Failed, and Error in the collapsed row.
Don't show new builds, but update the toast notification to say that the
build is queued.
Fixes #1687