Deprovision to Delete #1735
Merged
Deprovision to Delete #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
requested changes
Jun 19, 2017
| @@ -191,7 +191,7 @@ angular.module("openshiftConsole") | |||
| var uid = instance.metadata.uid; | |||
| var namespaceError = _.find(instance.status.conditions, {reason: 'ErrorFindingNamespaceForInstance'}); | |||
| var provisionFail = _.find(instance.status.conditions, {reason: 'ProvisionFailed'}); | |||
| var deprovisionFail = _.find(instance.status.conditions, {reason: 'DeprovisioningFailed'}); | |||
There was a problem hiding this comment.
this is an API status condition not a UI string, don't change this
Update from deprovision to delete copy
cdcabrera
force-pushed
the
issue-deprovision
branch
from
5cf3f96
to
f1aeaf1
Compare
jwforres
approved these changes
Jun 19, 2017
|
[merge][severity:bug] |
|
Evaluated for origin web console merge up to f1aeaf1 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1565/) (Base Commit: 59e53bf) (PR Branch Commit: f1aeaf1) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from deprovision to delete copy. Closes #1682