Send propagationPolicy null so that instances and bindings can be deleted cleanly #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on next release of common |
jwforres
force-pushed
the
delete-svc-cat-resources
branch
from
9bdd24a
to
5241d9b
Compare
|
LGTM |
openshift-bot
added
the
needs-rebase
|
Should we worry about the other resources page? Now that we have the aggregator, service catalog resources are showing up |
|
Yeah good catch, we should either block them from showing up or handle the
delete correctly there. Main reason I would consider having them not
showing up is the editing experience, I don't know how much of update the
svc catalog is handling properly.
On Jun 19, 2017 9:56 PM, "Sam Padgett" <[email protected]> wrote:
Should we worry about the other resources page? Now that we have the
aggregator, service catalog resources are showing up
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1739 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7eP2R776zyF3c3KbiIUMmEfZn36oks5sFybegaJpZM4N-qqM>
.
|
jwforres
force-pushed
the
delete-svc-cat-resources
branch
from
5241d9b
to
c7431d2
Compare
jwforres
changed the title
jwforres
force-pushed
the
delete-svc-cat-resources
branch
from
c7431d2
to
4bfb961
Compare
|
@spadgett updated to fix deleteLink, this should be good to merge now |
spadgett
approved these changes
Jun 20, 2017
|
[merge][severity:blocker] |
|
Evaluated for origin web console merge up to 4bfb961 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1572/) (Base Commit: 54c8cb2) (PR Branch Commit: 4bfb961) (Extended Tests: blocker) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openshift/origin-web-common#113