Watch for changes to the tab query parameter #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `persist-tab-state` directive, watch for changes to the `tab` query parameter so we can update the selected tab. This lets links to the same page, but a different tab, work (like the check events link in the `deployment-donut` quota warning).
jwforres
approved these changes
Jun 20, 2017
|
[merge][severity:bug] |
|
Evaluated for origin web console merge up to 0613ae6 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1576/) (Base Commit: aca7203) (PR Branch Commit: 0613ae6) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
persist-tab-statedirective, watch for changes to thetabquery parameter so we can update the selected tab. This lets links to
the same page, but a different tab, work (like the check events link in
the
deployment-donutquota warning).Fixes #1748