Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes visual defects around "Container:" labels #1757

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Fixes visual defects around "Container:" labels #1757

merged 1 commit into from
Jun 26, 2017

Conversation

rhamilto
Copy link
Member

Fixes #1180

screen shot 2017-06-21 at 4 39 03 pm

Bonus:

  • improves display of dash following container name
  • fixes alignment of container name on metrics tab

screen shot 2017-06-21 at 4 40 07 pm

@rhamilto rhamilto requested a review from spadgett June 21, 2017 20:40
@spadgett
Copy link
Member

Looks like we need to make the same vertical align change to the container name dropdown when there's more than one container:

openshift web console 2017-06-22 09-39-46

@spadgett
Copy link
Member

Fixes #1180

Bonus:

* improves display of dash following container name
* fixes alignment of container name on metrics tab
@rhamilto
Copy link
Member Author

Good catch, @spadgett. Fixed.
screen shot 2017-06-22 at 10 45 31 am

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for when the stream reopens

@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 646b10b

@openshift-bot
Copy link

openshift-bot commented Jun 26, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1593/) (Base Commit: 243e713) (PR Branch Commit: 646b10b)

@openshift-bot openshift-bot merged commit 733e9f2 into openshift:master Jun 26, 2017
@rhamilto rhamilto deleted the issue-1180 branch June 26, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No space between label and container name on logs tab
4 participants