Upgrade versions of catalog (0.0.27) and common (0.0.39) #1777
Conversation
| var ctrl = this; | ||
| var validityWatcher; | ||
| var bindingWatch; | ||
| var statusCondition = $filter('statusCondition'); | ||
| console.dir(ctrl.target); |
There was a problem hiding this comment.
Do we want this in production code?
There was a problem hiding this comment.
sorry, left over...
| ctrl.appToBind = null; | ||
| ctrl.serviceToBind = ctrl.target.metadata.name; | ||
| loadApplications(); | ||
| ProjectsService.get(ctrl.target.metadata.namespace).then(_.spread(function(project) { |
There was a problem hiding this comment.
This is going to cause another request for the project when we already have the project loaded
There was a problem hiding this comment.
where is the project?
There was a problem hiding this comment.
You should update the bindService component to take the project as a param, anywhere we are using that component the project has already been loaded by the main controller for the page
There was a problem hiding this comment.
in both list-row and service-instance-row its available as row.state.project
There was a problem hiding this comment.
Awesome. Thanks @jwforres !
There was a problem hiding this comment.
Updated. So much better. Thanks again.
Added project display name to common bind service form component.
|
[merge] |
|
Evaluated for origin web console merge up to f07da83 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1607/) (Base Commit: 2fb6223) (PR Branch Commit: f07da83) |
Added project display name to common bind service form component.