Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hamburger menu at mobile for pages with no project bar #2017

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Fix hamburger menu at mobile for pages with no project bar #2017

merged 1 commit into from
Sep 6, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Sep 6, 2017 •
edited
Loading

The hamburger menu was broken on some pages where it should show the utility nav (help and user menus).

rhamilto
rhamilto reviewed Sep 6, 2017
View reviewed changes
app/styles/_vertical-nav.less Outdated
}
.has-project-bar & {
top: (@navbar-os-header-height-mobile + @project-bar-height-mobile);
@media(min-width: @screen-sm-min) {
top: (@navbar-os-header-height-desktop + @project-bar-height-desktop);
display: block;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: alpha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

rhamilto
rhamilto approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

@spadgett
Copy link
Member Author

spadgett commented Sep 6, 2017

[merge][severity: blocker]

@openshift-bot
Copy link

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for origin web console test up to c5a33e4

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/140/) (Base Commit: 73c7420) (PR Branch Commit: c5a33e4)

@spadgett
Copy link
Member Author

spadgett commented Sep 6, 2017

Origin Web Console Test Results: FAILURE >
(https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/140/) (Base Commit: 73c7420) (PR Branch Commit: c5a33e4)

Flake #2016

@spadgett
Copy link
Member Author

spadgett commented Sep 6, 2017

[merge][severity: blocker]

@openshift-bot
Copy link

Evaluated for origin web console merge up to c5a33e4

@openshift-bot openshift-bot merged commit a6bf807 into openshift:master Sep 6, 2017
@openshift-bot
Copy link

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/133/) (Base Commit: becea5e) (PR Branch Commit: c5a33e4) (Extended Tests: blocker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@rhamilto rhamilto rhamilto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @openshift-bot @rhamilto @jeff-phillips-18