Avoid runtime error for some dockerconfigjson secrets #2057
Conversation
app/views/_config-file-params.html
Outdated
| <dd ng-if="!view.showSecret">*****</dd> | ||
| <dt>email</dt> | ||
| <dd class="word-break">{{data.email}}</dd> | ||
| <div ng-if="data.username || data.password || data.email"> |
There was a problem hiding this comment.
wondering if this is necessary/helpful, nothing will show if none exist anyhow.
There was a problem hiding this comment.
It looks a little odd to me because the header is underlined with nothing below. Opinion?
There was a problem hiding this comment.
Agreed. I would leave it.
There was a problem hiding this comment.
Oh, sorry, I was thinking of the div below when the data is missing. Yeah this div isn't needed, will fix
spadgett
force-pushed
the
dockerconfigjson-secret
branch
from
c5156ff
to
f30afc2
Compare
|
Thanks @jeff-phillips-18, updated |
|
[merge][severity: blocker] |
|
Flake #2016 [merge][severity: blocker] |
1 similar comment
|
Flake #2016 [merge][severity: blocker] |
|
Evaluated for origin web console merge up to f30afc2 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/180/) (Base Commit: 0200cf1) (PR Branch Commit: f30afc2) (Extended Tests: blocker) |
Fixes #2056