Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for created date not wrapping well with "Add to Application" button #2067

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Conversation

rhamilto
Copy link
Member

Fixes #2060

screen shot 2017-09-13 at 11 41 53 am

@spadgett
Copy link
Member

@rhamilto I wonder if we should add nowrap around the "created ..." message, but I'm sure that impacts a lot of pages.

@spadgett
Copy link
Member

[merge][severity: bug]

@spadgett
Copy link
Member

Origin Web Console Merge Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/188/) (Base Commit: f3fcba9) (PR Branch Commit: f5c5b51) (Extended Tests: bug)

Flake #2016, which is hopefully fixed by #2064. Will retag when #2064 merges

@spadgett
Copy link
Member

[merge][severity: bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to f5c5b51

@rhamilto
Copy link
Member Author

@rhamilto I wonder if we should add nowrap around the "created ..." message, but I'm sure that impacts a lot of pages.

Yeah. I went for the simpler fix since this only occurs roughly around 800px - 900px.

@spadgett
Copy link
Member

Works for me, thanks

@openshift-bot
Copy link

openshift-bot commented Sep 13, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/192/) (Base Commit: 1bb46a9) (PR Branch Commit: f5c5b51) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit f446b03 into openshift:master Sep 13, 2017
@rhamilto rhamilto deleted the issue-2060 branch September 13, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants