Don't show "Applications" as step label when pod presets are disabled #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
approved these changes
Sep 15, 2017
|
@spadgett I think that makes sense. Good catch. It must have just been an oversight that it said "applications" before. |
We used to show the name of the applications the service was bound to. Now that pod presets are disabled, it's always a secret. |
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to c0550de |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/203/) (Base Commit: 5bf079c) (PR Branch Commit: c0550de) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ncameronbritt Opinion on this change? The step title used to be "Applications". Noticed this after working on #2092