Fix issues with bindings widget for service instances #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't show "Create Binding" when service instance is not bindable - Fix empty content when there are no bindings and you don't have permission to add a binding - Don't request all service classes and plans to show bindings. This is a large amount of data when we usually have the service class and plan already
openshift-ci-robot
added
the
size/L
|
@jeff-phillips-18 PTAL. I created a separate component for instance bindings because it simplifies the logic and isn't a lot of code. Let me know what you think. |
jeff-phillips-18
approved these changes
Oct 17, 2017
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permission to add a binding
a large amount of data when we usually have the service class and plan
already
Fixes #2271
Fixes #2270