Added 'no projects and cant create' empty states

[dtaylor113]

Added to deploy-image, from-file, and process-template:

[dtaylor113]

/retest

[spadgett]

LGTM except for the one comment. PR will need rebase

[spadgett]

@dtaylor113 This is fine, but not needed. The $scope listeners are already deregistered on destroy. I'd honestly rather remove this logic from the controllers to keep the code simpler. It can just be...

$scope.$on('no-projects-cannot-create', function() {
  $scope.noProjectsCantCreate = true;
});

in each of the controllers without needing to handle the return value.

[dtaylor113]

Ok, fixed

[spadgett]

/retest

[spadgett]

Thanks @dtaylor113

/lgtm

[spadgett]

/lgtm

[spadgett]

/lgtm

[spadgett]

/retest

[spadgett]

@dtaylor113 Can you take a look at the test failures and make sure they're not due to your changes?

[dtaylor113]

@dtaylor113 Can you take a look at the test failures and make sure they're not due to your changes?

Looking at the Jenkins logs, seems like an issue with 4 or 5 e2e tests. At the moment I have to clear my docker cache and get oc to cluster up. I'll let you know if e2e works locally for me.

[dtaylor113]

Hi @spadgett, when I run the e2e tests locally I error out with:

Error: ECONNREFUSED connect ECONNREFUSED 10.193.20.254:43082
    at ClientRequest.<anonymous> (/home/dtaylor/Dev/repos/openshift/origin-web-console/node_modules/selenium-webdriver/http/index.js:145:16)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:308:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1271:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
==== async task ====
WebDriver.takeScreenshot()

I think this is just a general error trying to run selenium on my linux system.

Here is a link to the e2e test failures of this PR:
https://gist.github.com/dtaylor113/5049e774e24066cdbb5d288269d3c0e3

They don't appear to be related to the <select project> changes done in this PR.

[spadgett]

We keep seeing the same failures in your PR and not others. Those pages also use the select-project component, so it might be related.

/retest

[dtaylor113]

Hmm... @juanvallejo is getting the same stack trace reported here on his linux system, latest master. I also am seeing failures on my system using the latest master.

[spadgett]

@dtaylor113 But your failures are different than Jenkins, right?

[spadgett]

It might be safer to change these ng-if to ng-show (here and below) to avoid problems like openshift/origin-web-catalog#526

It might fix the test failures as well.

[dtaylor113]

Ok, replaced ng-if's with ng-shows's, e2e worked with Ben's latest e2e changes and seemed to get further just in this PRs branch. 🤞 Hopefully it'll pass Travis :-)

[spadgett]

/lgtm

[dtaylor113]

yay!!! \0/

[spadgett]

/lgtm

[openshift-merge-robot]

Automatic merge from submit-queue.