Bug 1504511 - Remember template values when clicking back #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing template parameter values, remember the values when the user clicks back and then forward again. This will still correctly clear the values if the user switches templates in the "Select from Project" dialog. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1504511
openshift-ci-robot
added
the
size/XS
jeff-phillips-18
approved these changes
Oct 20, 2017
|
Sounds like they're OK from the bug:
I'll double check |
|
The other dialogs remember parameters. |
jwforres
approved these changes
Oct 20, 2017
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing template parameter values, remember the values when the
user clicks back and then forward again. This will still correctly clear
the values if the user switches templates in the "Select from Project"
dialog.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1504511
@jeff-phillips-18 @jwforres