Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt renamed service external name properies #2347

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 23, 2017

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2017
@spadgett spadgett force-pushed the external-service-property-names branch from 23680ab to 3d4495e Compare October 25, 2017 11:30
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2017
origin-web-common 0.0.69 -> 0.0.70
origin-web-catalog 0.0.59 -> 0.0.60
@spadgett spadgett force-pushed the external-service-property-names branch from 3d4495e to 6369553 Compare October 25, 2017 17:53
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2017
@spadgett spadgett changed the title [WIP] Adopt renamed service external name properies Adopt renamed service external name properies Oct 25, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2017
@spadgett
Copy link
Member Author

Rebased and added dist. The origin changes have merged.

/assign @jwforres

@jwforres
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit a5bd9d6 into openshift:master Oct 25, 2017
@spadgett spadgett deleted the external-service-property-names branch October 25, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants