EnvFrom reveal/hide secrets within display modal #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
spadgett
reviewed
Oct 26, 2017
| </div> | ||
| <div class="modal-body"> | ||
| <h4>{{$ctrl.overlayPaneEntryDetails.metadata.name}} | ||
| <small class="muted">– {{$ctrl.overlayPaneEntryDetails.kind | humanizeKind : true}}</small></h4> | ||
| <small ng-if="$ctrl.overlayPaneEntryDetails.kind === 'Secret'" class="mar-left-sm"><a href="" ng-click="$ctrl.showSecret = !$ctrl.showSecret">{{$ctrl.showSecret ? "Hide" : "Reveal"}} Values</a></small> |
There was a problem hiding this comment.
role="button" on the a element
There was a problem hiding this comment.
We use "Reveal Secret" instead on the secret page. Probaby should be consistent here, too.
| <span ng-if="$ctrl.overlayPaneEntryDetails.kind === 'Secret'">*****</span> | ||
| <span ng-if="!$ctrl.showSecret && $ctrl.overlayPaneEntryDetails.kind === 'Secret'">*****</span> | ||
| <div ng-if="$ctrl.showSecret && $ctrl.overlayPaneEntryDetails.kind === 'Secret'"> | ||
| {{value}} |
There was a problem hiding this comment.
Use truncate-long-text here, too. Secret values can be long.
|
This is a small, low-risk change that fixes a usability problem. /kind bug |
openshift-ci-robot
added
the
kind/bug
cdcabrera
force-pushed
the
issue-envfrom-reveal
branch
from
d7048b9
to
c6f9716
Compare
cdcabrera
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
spadgett
approved these changes
Oct 30, 2017
openshift-merge-robot
added
the
needs-rebase
Reveal and hide secret value display within the EnvFrom modal
cdcabrera
force-pushed
the
issue-envfrom-reveal
branch
from
c6f9716
to
782f6e6
Compare
openshift-merge-robot
removed
lgtm
|
/lgtm |
|
/retest |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reveal and hide secret value display within the EnvFrom modal.
Related to issue #2182