Rework nav to remove :hover selectors to address bugs, inconsistencies #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@jwforres, would love your keen eyes on this, too. |
|
@rhamilto I don't see any issue with either the mouse or tab navigation behavior. Looks good! |
openshift-merge-robot
added
needs-rebase
|
I just force pushed some changes, so if you already pulled, delete your branch and recreate. |
|
Works great, @rhamilto |
rhamilto
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
spadgett
approved these changes
Oct 26, 2017
|
/lgtm |
|
/retest |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2373
Building on what @sg00dwin did in https://github.com/sg00dwin/origin-web-console/tree/vertical-nav-tab-issue2373%23issuecomment-339359101, this removes all :hover styling changes in order to forge consistency across hover, click, and tab navigation.
@sg00dwin, @spadgett, mind pulling these changes, testing, and seeing if everything is ok?