-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to membership page to prevent breaking. This is a back port of an initial fix that went in 3.7. #2807
Merged
openshift-merge-robot
merged 1 commit into
openshift:enterprise-3.6
from
sg00dwin:membership-fix-3.6
Feb 19, 2018
Merged
Updates to membership page to prevent breaking. This is a back port of an initial fix that went in 3.7. #2807
openshift-merge-robot
merged 1 commit into
openshift:enterprise-3.6
from
sg00dwin:membership-fix-3.6
Feb 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f an initial fix that went in 3.7. Original pr openshift#2344 Fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=1545089
openshift-ci-robot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Feb 16, 2018
/assign @rhamilto |
benjaminapetersen
approved these changes
Feb 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but will let @rhamilto give it the final pass.
/retest |
rhamilto
approved these changes
Feb 16, 2018
/retest |
/lgtm |
Looks like flake #2105 /retest |
/retest |
server failed to start /retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pr #2344
Fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=1545089