Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to membership page to prevent breaking. This is a back port of an initial fix that went in 3.7. #2807

Merged

Conversation

sg00dwin
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2018
@sg00dwin
Copy link
Member Author

cc @rhamilto @benjaminapetersen

@spadgett
Copy link
Member

/assign @rhamilto

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will let @rhamilto give it the final pass.

@spadgett
Copy link
Member

/retest

@rhamilto
Copy link
Member

/retest

@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2018
@spadgett
Copy link
Member

Looks like flake #2105

/retest

@spadgett
Copy link
Member

/retest

@benjaminapetersen
Copy link
Contributor

server failed to start

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit ceae162 into openshift:enterprise-3.6 Feb 19, 2018
@sg00dwin sg00dwin deleted the membership-fix-3.6 branch February 19, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants