hack/lib/start.sh uses openshift start

[dmage]

openshift start was removed in #20344, but our hack scripts still use it (for example, make test-extended, os::start::all_in_one).

[dmage]

/cc @smarterclayton @stevekuznetsov @bparees

[bparees]

/assign @smarterclayton @deads2k

[dmage]

For those who will hit the same problem:

$ oc cluster up --tag=latest
$ oc login -u system:admin
$ KUBECONFIG=~/.kube/config TEST_ONLY=1 make test-extended SUITE="core"

[smarterclayton]

I think I'll probably just remove the magic of test-extended starting a cluster (make TEST_ONLY=1 the only supported behavior)

[stevekuznetsov]

Can we poll for consensus on openshift-dev@ first?

[bparees]

i haven't used make test-extended in years... i've always started my own cluster and used TEST_ONLY=1.

[enj]

@openshift/sig-security both the LDAP and GSSAPI extended tests are now broken.

Wrote master config to: /tmp/openshift/ldap_groups/openshift.local.config/master/master-config.yaml
Running hack/lib/start.sh:341: executing 'oc get --raw /healthz --as system:unauthenticated --config='/tmp/openshift/ldap_groups/openshift.local.config/master/admin.kubeconfig'' expecting any result and text 'ok'; re-trying every 0.25s until completion or 80.000s...
FAILURE after 79.581s: hack/lib/start.sh:341: executing 'oc get --raw /healthz --as system:unauthenticated --config='/tmp/openshift/ldap_groups/openshift.local.config/master/admin.kubeconfig'' expecting any result and text 'ok'; re-trying every 0.25s until completion or 80.000s: the command timed out
Standard output from the command:
Standard error from the command:
The connection to the server 172.18.7.243:8443 was refused - did you specify the right host or port?
... repeated 187 times
[ERROR] PID 28940: hack/lib/cmd.sh:617: `return "${return_code}"` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/lib/cmd.sh:617: `return "${return_code}"`
[INFO] 		  2: hack/lib/start.sh:341: os::cmd::try_until_text
[INFO] 		  3: hack/lib/start.sh:227: os::start::all_in_one
[INFO] 		  4: test/extended/ldap_groups.sh:30: os::start::server
[INFO]   Exiting with code 1.
/data/src/github.com/openshift/origin/hack/lib/log/system.sh: line 31: 29037 Terminated              sar -A -o "${binary_logfile}" 1 86400 > /dev/null 2> "${stderr_logfile}"
[INFO] No compiled `junitreport` binary was found. Attempting to build one using:

Wrote master config to: /tmp/openshift/gssapi/openshift.local.config/master/master-config.yaml
Running hack/lib/start.sh:341: executing 'oc get --raw /healthz --as system:unauthenticated --config='/tmp/openshift/gssapi/openshift.local.config/master/admin.kubeconfig'' expecting any result and text 'ok'; re-trying every 0.25s until completion or 80.000s...
FAILURE after 79.701s: hack/lib/start.sh:341: executing 'oc get --raw /healthz --as system:unauthenticated --config='/tmp/openshift/gssapi/openshift.local.config/master/admin.kubeconfig'' expecting any result and text 'ok'; re-trying every 0.25s until completion or 80.000s: the command timed out
Standard output from the command:
Standard error from the command:
The connection to the server 172.18.11.24:8443 was refused - did you specify the right host or port?
... repeated 185 times
[ERROR] PID 28874: hack/lib/cmd.sh:617: `return "${return_code}"` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/lib/cmd.sh:617: `return "${return_code}"`
[INFO] 		  2: hack/lib/start.sh:341: os::cmd::try_until_text
[INFO] 		  3: hack/lib/start.sh:227: os::start::all_in_one
[INFO] 		  4: test/extended/gssapi.sh:49: os::start::server
[INFO]   Exiting with code 1.
[ERROR] Expected no test suites to be marked as in-flight at the end of testing, got 1
make: *** [test-extended] Error 1
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: RUN EXTENDED TESTS [00h 01m 26s] ##########

[smarterclayton]

There is no support path now without oc cluster up that involves a node. Anyone who needs a node in those tests should be using oc cluster up or the correct extended flow, anyone who doesn't need a node should stop using start::all_in_one.

[stevekuznetsov]

Whoever made the change should update start::all_in_one so their change doesn't break people

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.