Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pull request will pass the tests in release-3.10 as the tests fail without any change in the code #22639

Closed
soukron opened this issue Apr 23, 2019 · 8 comments
Assignees
Labels
area/tests kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@soukron
Copy link

soukron commented Apr 23, 2019

I'm trying to get a PR (#22500) merged but tests fail while my files are not involved.

I've sent an "empty" pull request (#22637) with a new-line in the README.md file and the result is the same. Some of the required test fail.

Steps To Reproduce
  1. Clone this repo
  2. Checkout to release-3.10
  3. Create a new file
  4. Send the pull-request and let the test run
Current Result

Required tests fail.

Expected Result

Tests should work by default. Otherwise people sending pull-requests will frustrate/confuss with errors not related with their own changes.

@soukron
Copy link
Author

soukron commented May 6, 2019

@sjenning @smarterclayton @stevekuznetsov any feedback? How is release-3.10 being tested?

@stevekuznetsov
Copy link
Contributor

Are we accepting PRs to release-3.10? Must be best-effort then. I can't tell what's wrong with the unit test in that dummy pR

@soukron
Copy link
Author

soukron commented May 9, 2019

@stevekuznetsov I hope you're accepting PRs, otherwise this backport won't reach the release #22500.

I submitted the empty PR to prove that there's no issue in the code in the backport PR but in the current released code (or in the tests), which fails in unit tests.

@stevekuznetsov
Copy link
Contributor

@smarterclayton @jwforres PTAL

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2019
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 6, 2019
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants