S2i 5009651 bump #11414
S2i 5009651 bump #11414
Conversation
|
[test] |
|
[testextended][extended:core(builds)] |
|
[testextended][extended:core(image_ecosystem)] |
|
@PI-Victor fyi |
|
Evaluated for origin testextended up to 6c4d26e |
|
Evaluated for origin test up to 6c4d26e |
| // return &TimeoutError{} | ||
| // } | ||
| // timer.Reset(timeout) | ||
| func TimeoutAfter(t time.Duration, errorMsg string, f func(*time.Timer) error) error { |
There was a problem hiding this comment.
@bparees @jim-minter thanks for the merge.
just a curiosity, this whole thing, couldn't we replace it with this: https://golang.org/pkg/time/#AfterFunc
or am i reading the scope of the function wrong?
There was a problem hiding this comment.
@PI-Victor
time.AfterFunc waits T, then runs f()
this function runs f(), concurrently waits T and returns if f() hasn't finished by then.
There was a problem hiding this comment.
@jim-minter yeah, you're right. makes sense now.
thanks for the clarification
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10183/) (Base Commit: f6bd74b) |
|
@jim-minter thanks for patching the holes in openshift in this PR introduced by me, i completely forgot to mention that :) |
|
continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/624/) (Base Commit: 5134734) (Extended Tests: core(image_ecosystem), core(builds)) |
|
Run separately those tests both passed: |
|
extended tests all passed independently: |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10183/) (Image: devenv-rhel7_5211) |
|
Evaluated for origin merge up to 6c4d26e |
No description provided.