-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show SCC provider in error message #13842
Show SCC provider in error message #13842
Conversation
I see that we're missing information about container here origin/vendor/k8s.io/kubernetes/pkg/securitycontextconstraints/provider.go Lines 299 to 307 in ec4262b
Validate() accepts only container and inside the method there is no information whether it was init-container or not and what is the index of a container.
In the error message that I provided the first error relates to the init container but two others relate to a simple container. |
BTW original issue is also exist in kubernetes where |
@pweil- Gently ping :) |
I don't see any sensitive information leaking here and it indeed improves the messaging. LGTM (but will defer to @pweil- for merge ;-) |
[test] |
I've created a separate issue for that: #13909 |
Tests failed because of #13619 |
[test] Ping @pweil- |
Ping @pweil- |
Evaluated for origin test up to 0b87377 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1682/) (Base Commit: 67275e1) |
test flake #14328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mfojtik Can we merge it? |
@mfojtik Ping. I don't see a reason of not merging it. |
[merge] sorry for the delay |
@mfojtik Could you re-run merge process, please? |
@mfojtik and this one too, please :) |
[merge]
…On 14 June 2017 at 16:42:23, Vyacheslav Semushin ***@***.***) wrote:
@mfojtik <https://github.com/mfojtik> and this one too, please :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13842 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACsaK30gObeq4DMxnYj1Xxvf90fyK8iks5sD_FPgaJpZM4NDX0t>
.
|
Evaluated for origin merge up to 0b87377 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/994/) (Base Commit: e87bd0c) (Image: devenv-rhel7_6358) |
Let's use parameter
fldPath
in theAssignSecurityContext
function. In this case provider name is included in the error message that is super helpful during debug.Before:
After
This message is also including in the
FailedCreate
event. The message still hard to read but now it contains helpful information.PTAL @pweil-