Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "disable image-references" #13990

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 2, 2017

This PR reverts #13925 and fixes #13924

I've run this multiple times locally and several times on aws. I want to see the failure in aws, so I'll run the test at least few times before merging.

@soltysh
Copy link
Contributor Author

soltysh commented May 2, 2017

[test]

@soltysh
Copy link
Contributor Author

soltysh commented May 2, 2017

[test]

@soltysh
Copy link
Contributor Author

soltysh commented May 2, 2017

Flake #8571.

[test]

@ncdc
Copy link
Contributor

ncdc commented May 3, 2017

[test] #13942

@soltysh
Copy link
Contributor Author

soltysh commented May 4, 2017

One last run if I don't see failure I'd like to get it merged. @ncdc @deads2k any objectsions?

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4cad052

@ncdc
Copy link
Contributor

ncdc commented May 4, 2017 via email

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1143/) (Base Commit: dcd60bd)

@soltysh
Copy link
Contributor Author

soltysh commented May 4, 2017

I got 5 clean runs, based on approval:

[merge]

@soltysh
Copy link
Contributor Author

soltysh commented May 4, 2017

Flakes: #13942, #12264, #11016, #10773

[merge]

@soltysh
Copy link
Contributor Author

soltysh commented May 15, 2017

Flake: #13942

[merge]

@soltysh
Copy link
Contributor Author

soltysh commented May 15, 2017

Flake/error #14190

[merge]

@soltysh
Copy link
Contributor Author

soltysh commented May 15, 2017

Flake #14190

[merge]

@liggitt
Copy link
Contributor

liggitt commented May 31, 2017

is resolving the issue with this test a blocker?

@smarterclayton
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4cad052

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/922/) (Base Commit: 58ce257) (Image: devenv-rhel7_6328)

@openshift-bot openshift-bot merged commit cf5c12f into openshift:master Jun 8, 2017
@soltysh soltysh deleted the issue13924 branch June 8, 2017 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oadm migrate image-references fails in CI
5 participants