[POST-REBASE] UPSTREAM:45918: fix --local flag for oc set subcommands #14211

juanvallejo · 2017-05-16T03:53:34Z

Fixes #14180
Fixes --local flag for oc set ... subcommands.
Addresses #14123 (comment)

Before (With no connection to a cluster)

$ oc set env --local -f ./mydc.json ENV="deploymentconfig"

error: dial tcp 127.0.0.1:8443: getsockopt: connection refused

After (With no connection to a cluster)

NAME      REVISION   DESIRED   CURRENT   TRIGGERED BY
mydc   1          1         1         config,image(mydc:latest)

Affected oc commands

oc set build-hook
oc set probe
oc set resources (fix --local flag for kubectl commands kubernetes/kubernetes#45918)
~~[x] oc set triggers (Fixes Flake: oc set trigger #14180)~~
oc set volume
oc set env
oc set deployment-hook
oc set build-secret
oc set route-backends

cc @openshift/cli-review @smarterclayton

juanvallejo · 2017-05-16T03:54:31Z

[test]

juanvallejo · 2017-06-16T18:45:33Z

[test]

csrwng · 2017-06-16T19:04:47Z

LGTM

juanvallejo · 2017-06-20T20:33:04Z

flaked on #13271 re[test]

juanvallejo · 2017-06-21T14:48:52Z

flaked on #13271 re[test]

juanvallejo · 2017-06-21T22:02:48Z

cc @fabianofranz

fabianofranz · 2017-06-22T15:01:42Z

LGTM, @liggitt you ok with picking this UPSTREAM commit?

liggitt · 2017-07-10T02:30:47Z

if the flake is fixed, can the bigger change wait for the 1.7 rebase?

Adds `allowRemoteCalls` bool arg to f.NewBuilder that returns a "DisabledClientForMapping" when bool arg is false, allowing a common method to be used in local and non-local commands.

juanvallejo · 2017-07-10T16:53:43Z

@liggitt sure, will tag post-rebase

openshift-bot · 2017-07-10T16:55:28Z

Evaluated for origin test up to d179a5e

openshift-bot · 2017-07-10T18:42:31Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3034/) (Base Commit: fe7173b) (PR Branch Commit: d179a5e)

openshift-bot · 2017-07-17T01:47:19Z

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

openshift-merge-robot · 2017-07-25T19:00:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-07-28T22:07:44Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-07-28T22:35:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-bot · 2018-02-16T10:51:43Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

juanvallejo · 2018-02-20T19:40:38Z

/close
Origin already has these changes through a rebase.

juanvallejo changed the title ~~[WIP] fix --local for env,probe cmds~~ [WIP] fix --local flag for oc set subcommands May 16, 2017

juanvallejo force-pushed the jvallejo/fix-local-flag-set-cmds branch 2 times, most recently from 0506034 to 7b2ca82 Compare May 16, 2017 18:48

juanvallejo changed the title ~~[WIP] fix --local flag for oc set subcommands~~ [WIP] UPSTREAM:0000: fix --local flag for oc set subcommands May 16, 2017

juanvallejo force-pushed the jvallejo/fix-local-flag-set-cmds branch 2 times, most recently from 08cad74 to d1771ba Compare May 16, 2017 20:30

juanvallejo mentioned this pull request May 16, 2017

fix --local flag for kubectl commands kubernetes/kubernetes#45918

Merged

juanvallejo changed the title ~~[WIP] UPSTREAM:0000: fix --local flag for oc set subcommands~~ UPSTREAM:45918: fix --local flag for oc set subcommands May 16, 2017

juanvallejo force-pushed the jvallejo/fix-local-flag-set-cmds branch 2 times, most recently from 12df03f to 283bb95 Compare June 16, 2017 18:42

juanvallejo requested review from csrwng and fabianofranz June 16, 2017 18:43

juanvallejo force-pushed the jvallejo/fix-local-flag-set-cmds branch 2 times, most recently from f67ef22 to 225947c Compare June 20, 2017 16:34

juanvallejo force-pushed the jvallejo/fix-local-flag-set-cmds branch from 225947c to 332d67f Compare June 21, 2017 19:59

juanvallejo mentioned this pull request Jun 29, 2017

Flake: oc set trigger #14180

Closed

juanvallejo added 2 commits July 10, 2017 12:53

UPSTREAM: 45918: update f.NewBuilder

bbfdf07

Adds `allowRemoteCalls` bool arg to f.NewBuilder that returns a "DisabledClientForMapping" when bool arg is false, allowing a common method to be used in local and non-local commands.

fix --local flag for oc set cmds

d179a5e

juanvallejo force-pushed the jvallejo/fix-local-flag-set-cmds branch from 332d67f to d179a5e Compare July 10, 2017 16:53

juanvallejo added the kind/post-rebase label Jul 10, 2017

fabianofranz changed the title ~~UPSTREAM:45918: fix --local flag for oc set subcommands~~ [POST-REBASE] UPSTREAM:45918: fix --local flag for oc set subcommands Jul 10, 2017

fabianofranz added the component/cli label Jul 10, 2017

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2017

openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2017

openshift-merge-robot assigned liggitt and smarterclayton Jul 25, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017

openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017

openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 14, 2017

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2018

juanvallejo closed this Feb 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[POST-REBASE] UPSTREAM:45918: fix --local flag for oc set subcommands #14211

[POST-REBASE] UPSTREAM:45918: fix --local flag for oc set subcommands #14211

juanvallejo commented May 16, 2017 •

edited

Loading

juanvallejo commented May 16, 2017

juanvallejo commented Jun 16, 2017

csrwng commented Jun 16, 2017

juanvallejo commented Jun 20, 2017

juanvallejo commented Jun 21, 2017

juanvallejo commented Jun 21, 2017

fabianofranz commented Jun 22, 2017

liggitt commented Jul 10, 2017

juanvallejo commented Jul 10, 2017

openshift-bot commented Jul 10, 2017

openshift-bot commented Jul 10, 2017

openshift-bot commented Jul 17, 2017

openshift-merge-robot commented Jul 25, 2017

openshift-merge-robot commented Jul 28, 2017

openshift-merge-robot commented Jul 28, 2017

openshift-bot commented Feb 16, 2018

juanvallejo commented Feb 20, 2018

[POST-REBASE] UPSTREAM:45918: fix --local flag for oc set subcommands #14211

[POST-REBASE] UPSTREAM:45918: fix --local flag for oc set subcommands #14211

Conversation

juanvallejo commented May 16, 2017 • edited Loading

Affected oc commands

juanvallejo commented May 16, 2017

juanvallejo commented Jun 16, 2017

csrwng commented Jun 16, 2017

juanvallejo commented Jun 20, 2017

juanvallejo commented Jun 21, 2017

juanvallejo commented Jun 21, 2017

fabianofranz commented Jun 22, 2017

liggitt commented Jul 10, 2017

juanvallejo commented Jul 10, 2017

openshift-bot commented Jul 10, 2017

openshift-bot commented Jul 10, 2017

openshift-bot commented Jul 17, 2017

openshift-merge-robot commented Jul 25, 2017

openshift-merge-robot commented Jul 28, 2017

openshift-merge-robot commented Jul 28, 2017

openshift-bot commented Feb 16, 2018

juanvallejo commented Feb 20, 2018

juanvallejo commented May 16, 2017 •

edited

Loading