Split resource and non-resource rules during conversion #14454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes makes it so that Origin PolicyRules that reference both resources and non-resources are split during conversion to RBAC PolicyRules. RBAC does not allow a rule to specify both and will fail validation in such cases. Since the conversion is unambiguous, we can do it automatically to prevent end users from having to deal with it when we switch over to RBAC. Signed-off-by: Monis Khan <[email protected]>
|
[test] |
|
Evaluated for origin test up to 953471c |
|
lgtm |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1907/) (Base Commit: 5f2f3f4) |
|
Confirmed that Jordan was happy with this. Merging since we need this for 3.6. [merge][severity: blocker] |
|
Evaluated for origin merge up to 953471c |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/886/) (Base Commit: dcf2e0c) (Extended Tests: blocker) (Image: devenv-rhel7_6296) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes it so that Origin
PolicyRulesthat reference both resources and non-resources are split during conversion to RBACPolicyRules. RBAC does not allow a rule to specify both and will fail validation in such cases. Since the conversion is unambiguous, we can do it automatically to prevent end users from having to deal with it when we switch over to RBAC.Signed-off-by: Monis Khan [email protected]