Cleaned up the matchPattern regex code #14552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
knobunc
commented
Jun 9, 2017
knobunc
commented
- Changed it to use raw strings to reduce the leaning-toothpick syndrome from all of the necessary escaping
- Changed it to use \A and \z around the regex, so that if the regex is put into multi-line mode with (?m) then it will match the whole string
- Changed it so that the () around their regex is (?:) to make it non-capturing
- Changed it to use raw strings to reduce the leaning-toothpick syndrome from all of the necessary escaping - Changed it to use \A and \z around the regex, so that if the regex is put into multi-line mode with (?m) then it will match the whole string - Changed it so that the () around their regex is (?:) to make it non-capturing
knobunc
force-pushed
the
fix/matchPattern-regex
branch
from
b40944d
to
ff3b23c
Compare
|
[test] @openshift/networking PTAL |
|
*cough* unit tests *cough* |
Added testing of the patternMatch function that can be called from the template. This does some basic positive and negative testing of patterns, and then has some more sophisticated tests to make sure the additional structure we add around the regex to anchor it to match the entire string does not misbehave.
|
Evaluated for origin test up to 35da20c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2073/) (Base Commit: 0f82878) |
|
LGTM |
1 similar comment
|
LGTM |
|
@danwinship thanks for the hint :-) Done. |
|
[merge] |
|
[merge] last flaked on #14353, logs: https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/975/ |
|
Evaluated for origin merge up to 35da20c |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/984/) (Base Commit: a5b8471) (Image: devenv-rhel7_6350) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.