Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generate informers for cluster resource quota #14567

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Use generate informers for cluster resource quota #14567

merged 1 commit into from
Jun 15, 2017

Conversation

smarterclayton
Copy link
Contributor

Builds on the other changes to remove handwritten informers, only the
last commit is new.

[test] @deads2k

@smarterclayton smarterclayton force-pushed the quotainformer branch 4 times, most recently from 42fc925 to 844abae Compare June 12, 2017 15:25
deads2k
deads2k reviewed Jun 12, 2017
View reviewed changes
pkg/cmd/server/origin/master.go
@@ -51,7 +51,7 @@ func (c *MasterConfig) newOpenshiftAPIConfig(kubeAPIServerConfig apiserver.Confi
KubeletClientConfig: c.KubeletClientConfig,
KubeInternalInformers: c.Informers.InternalKubernetesInformers(),
AuthorizationInformers: c.AuthorizationInformers,
DeprecatedInformers: c.Informers,
QuotaInformers: c.QuotaInformers,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes me happy.

deads2k
deads2k reviewed Jun 12, 2017
View reviewed changes
pkg/controller/shared/shared_informer.go
@@ -97,18 +90,6 @@ func (f *sharedInformerFactory) Start(stopCh <-chan struct{}) {
}
}

func (f *sharedInformerFactory) StartCore(stopCh <-chan struct{}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@deads2k
Copy link
Contributor

deads2k commented Jun 12, 2017

lgtm [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 8

@smarterclayton
Copy link
Contributor Author

[merge]

@smarterclayton
Copy link
Contributor Author

Unable to tell what flaked

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8fa91e2

@smarterclayton
Copy link
Contributor Author 

github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node.TestCancelAndReadd (from github.com_openshift_origin_vendor_k8s.io_kubernetes_pkg_controller_node)

Failing for the past 1 build (Since Failed#2217 )
Took 0 ms.
add description
Stacktrace

=== RUN   TestCancelAndReadd
panic: sync: negative WaitGroup counter

goroutine 402 [running]:
panic(0x23db480, 0xc4204636e0)
	/usr/local/go/src/runtime/panic.go:500 +0x1ae
sync.(*WaitGroup).Add(0xc4203e28b0, 0xffffffffffffffff)
	/usr/local/go/src/sync/waitgroup.go:75 +0x27c
sync.(*WaitGroup).Done(0xc4203e28b0)
	/usr/local/go/src/sync/waitgroup.go:100 +0x42
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node.TestCancelAndReadd.func1(0xc4204f6c60, 0xc400000001, 0xc400000020)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node/timed_workers_test.go:118 +0x65
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node.(*TimedWorkerQueue).getWrappedWorkerFunc.func1(0xc4204f6c60, 0x0, 0x0)
	github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node/_test/_obj_test/timed_workers.go:90 +0xb6
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/node.CreateWorker.func1()

@smarterclayton
Copy link
Contributor Author

[severity:bug]

@smarterclayton
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8fa91e2

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2256/) (Base Commit: eb50c84)

@smarterclayton smarterclayton merged commit dc2fa5a into openshift:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smarterclayton @deads2k @openshift-bot